Skip to content

add ruby 2.5 to appveyor#663

Merged
aycabta merged 1 commit into
ruby:masterfrom
colby-swandale:add-ruby25-to-appveyor
Dec 3, 2018
Merged

add ruby 2.5 to appveyor#663
aycabta merged 1 commit into
ruby:masterfrom
colby-swandale:add-ruby25-to-appveyor

Conversation

@colby-swandale

Copy link
Copy Markdown
Member

This PR is just adding Ruby 2.5 to appveyor CI. I think this was just forgotten about when it was released.

@colby-swandale

Copy link
Copy Markdown
Member Author

I've just realised that appveyor has been disconnected while you're waiting for evanphx/kpeg#37 #576 to be fixed. So feel free to close this.

@aycabta

aycabta commented Nov 11, 2018

Copy link
Copy Markdown
Member

I'll review and respond to this later, I escaped from CA fire accident right now. Please wait.

@colby-swandale

Copy link
Copy Markdown
Member Author

No rush! Hope you're safe!

@aycabta

aycabta commented Dec 1, 2018

Copy link
Copy Markdown
Member

This Pull Request will be merged after #672.

@aycabta aycabta merged commit 0a59591 into ruby:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants