Revert "Revert "Split up newline token"" - #4205
Merged
Merged
Conversation
This reverts commit 115d58f.
tompng
pushed a commit
to ruby/rdoc
that referenced
this pull request
Aug 10, 2026
In the next major version of Prism, the comment token is going to be split up when it is a non embdoc comment and when it terminates an expression. This diff makes the tests support both. In theory this should have no user-facing consequences because it does not matter if you colorize the newline or not. This will let me merge ruby/prism#4205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4201