fix : add gettext angular dependency + add module path option for requirejs#86
Open
davidostermann wants to merge 14 commits intorubenv:masterfrom
Open
fix : add gettext angular dependency + add module path option for requirejs#86davidostermann wants to merge 14 commits intorubenv:masterfrom
davidostermann wants to merge 14 commits intorubenv:masterfrom
Conversation
Collaborator
|
What problem is this attempting to solve? Also, we can't merge this if it's breaking tests. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I try to add have the possibility to have angular-gettext as a requirejs dependency.
I don't think it's a good idea to have angular as requirejs dependency and angular-gettext as a classic script embed.
In general, it should not be a requirement to have angular as requirejs dependencies. I tried to change the test in this way but I failed to get the test working without the angular dependency.
I also need the possibility to add an explicite name to the created requirejs module.