Fix: translations loading earlier warning #2275
Merged
NoumaanAhamed merged 2 commits intodevelopfrom Jan 30, 2026
Merged
Conversation
Contributor
|
Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:
The error may be temporary. If the error persists, please contact a human (commit-ID: 4cdafb3). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a translation loading issue by deferring the initialization of translatable strings from the constructor to the init action hook. However, this introduces a critical bug.
Changes:
- Moved translation string initialization from
__construct()to a newinit_translations()method hooked to theinitaction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue at #2273
This fix ensures translations are loaded at the init action, and will resolve the PHP notice about
_load_textdomain_just_in_timebeing called incorrectly.