Feat/support-immutable-4 - #44
Open
Aghassi wants to merge 1 commit into
Open
Conversation
This is a breaking change that attempts to provide support for Immutable v4 which was just released. However, the merge function was modified to ensure that objects could not be mutated. The tests in this repo seem to assume that mutation should be possible so I had to update the test to reflect the new usage. This is potentially breaking to any consumers of this repo that are relying on that feature
Author
|
@rt2zz would love to work with you to get this change properly vetted and in. There's a lot of changes, but being able to support V4 will be very helpful as my team migrates. I know the current state is probably "not ideal" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change that attempts to provide support
for Immutable v4 which was just released. However, the merge
function was modified to ensure that objects could not be mutated.
The tests in this repo seem to assume that mutation should be possible
so I had to update the test to reflect the new usage. This is potentially
breaking to any consumers of this repo that are relying on
that feature