fix: respect PartsExclude in writeFields#767
Open
ricardbejarano wants to merge 1 commit into
Open
Conversation
Fields listed in PartsExclude were only excluded from writePart (standard fields rendered via PartsOrder), but were still rendered by writeFields, causing them to appear in the trailing key=value section of the output. Fix writeFields to also skip fields listed in PartsExclude. Fixes rs#722 Signed-off-by: Tommy <tommy@bejarano.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fields listed in
PartsExcludewere only excluded fromwritePart(which handles standard fields likelevel,time,message, and custom fields rendered viaPartsOrder), but were still rendered bywriteFields, causing them to appear in the trailingkey=valuesection of the output.This PR fixes
writeFieldsto also skip fields listed inPartsExclude.Related Issue
Fixes #722
Changes
console.go: InwriteFields, skip any field that is listed inPartsExcludeconsole_test.go: Add test verifying thatPartsExcludesuppresses fields from bothwritePartandwriteFields