Fix instability in diode_test on darwin#765
Open
IDisposable wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR stabilizes diode_test.go by removing a race in TestNewWriter where the test could assert on the buffer before the diode’s background goroutine had written the log entry (observed as flaky failures on darwin CI).
Changes:
- Add a
signalBufferwrapper that signals when aWritehas occurred. - Update
TestNewWriterto wait (with a timeout) for the write signal before closing and asserting output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Applied same pattern to the other diode_test methods because now they race. Simplified to remove the sub-process now that zerolog supports replaceable FatalExitFunc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a subtle race condition in the diode_test.go that randomly fails the CI build's test (usually on darwin). This introduces a signal to ensure the diode writer did the write.