WARE-176: rotate on empty OpenAI chat completion - #5243
Open
warelik wants to merge 1 commit into
Open
Conversation
Empty chat.completions 200 was treated as success. Detect semantic emptiness and retry the next auth. First slice of router-for-me#4881.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c52de4283f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First narrow slice of #4881: treat an empty OpenAI chat-completions success as a retriable auth failure and rotate to the next credential on non-streaming
Execute.Parent #4881 stays open. This PR does not replace it.
Semantic emptiness for this slice (OpenAI
choicesonly):nullbody{"choices":[]}content:""withfinish_reason: stopand zerocompletion_tokensidonly, no name/arguments)[DONE]with no contentNot empty: visible text, refusal, named tool-call, audio, images,
completion_tokens > 0. Other wire formats (Claude, Gemini, Responses, Interactions) are out of scope and are not classified as empty here.Size
3 files, +854 / −0 vs
dev. Over the ~400-line target because the OpenAI semantic detector is one compilable unit: splitting the detector from theExecutehook leaves an unused library; dropping skeleton tool-calls reopens a named false-life hole. Tests fail on currentdevand pass after this change.Cutoff
The finding set for this artifact is closed. Further auto-review rounds will be recorded and not actioned, except the closed list: secret leak, data loss, resource leak, compatibility break. This artifact is ready for maintainer review.
Follow-up slices of #4881: stream+drain, Claude, Gemini+signature-only, Responses/Interactions, pluginhost, in-band error redaction, remaining glue.