fix(claude): write non-stream reasoning to canonical reasoning_content - #5145
fix(claude): write non-stream reasoning to canonical reasoning_content#5145warelik wants to merge 1 commit into
Conversation
Port of kaitranntt/CLIProxyAPIPlus#193 to stock. Reasoning_content field is already used; this adds parity, absence, and redacted_thinking coverage, and tightens the existing reasoning test.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b91f4e368
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| func TestConvertClaudeResponseToOpenAINonStream_OmitsReasoningContentWhenAbsent(t *testing.T) { |
There was a problem hiding this comment.
This commit modifies only internal/translator/, which repository policy prohibits unless the required gh repo view --json viewerPermission -q .viewerPermission check confirms WRITE, MAINTAIN, or ADMIN; in the inspected environment that command cannot authenticate, so authorization cannot be confirmed. Verify the permission under the submitting identity before landing this change, or follow the documented issue-only path.
AGENTS.md reference: AGENTS.md:L49-L50
Useful? React with 👍 / 👎.
|
This PR touches internal/translator/ and therefore fails the translator-path-guard workflow, which blocks any PR in that path from a READ-only account. I have opened #5148 with the defect description, root cause file:line, and proposed patch. This PR is left open as a ready reference implementation for the maintenance team. |
1 participant
Stock port of kaitranntt/CLIProxyAPIPlus#193.
Ensures Claude → OpenAI non-stream conversion writes thinking output to
choices.0.message.reasoning_contentinstead of the legacyreasoningfield, matching the streaming path.
This change closes the stock side of the Plus fix and keeps the two
repos in sync.