Add section on boolean substitutions#6864
Conversation
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with minor comment. i would like to have 2nd approval on this before merge.
| - Python class | ||
| - Description | ||
| * - ``$(equals A B)`` | ||
| - ``EqualsSubstitution`` |
There was a problem hiding this comment.
(this does not block the PR) Worth a one-sentence note in the table or just below it: "Comparison is performed on the string representation of each argument."??
There was a problem hiding this comment.
thank you, this is a very good idea! I've added it as a note above the table hoping it's a better spot to capture some eyes
fujitatomoya
added
backport-jazzy
kscottz
left a comment
kscottz
left a comment
There was a problem hiding this comment.
Made one suggestion. I am sure this will certainly help someone out so let's get it merged.
I will say, man, the syntax for booleans in every type of launch file is absolutely ugly. It hurts my eyes.
Co-authored-by: Katherine Scott <katherineAScott@gmail.com> Signed-off-by: Bence Magyar <bence.magyar.robotics@gmail.com>
|
I think I've addressed all your points, thank you guys for the snap reviews! |
3 participants
Description
I've finally come across the
equalsfunctionality and other features from ros2/launch#649 and though it'd be good to have them represented on this documentation.I wasn't sure if referencing the PR in the docs was a good idea so I didn't do that.
The changes were tested in vanilla Jazzy and Lyrical containers.
Did you use Generative AI?
Claude Opus 4.7