correct [[deprecated]] attribute placement on class#3142
Open
EricX-Zhao wants to merge 1 commit intoros2:rollingfrom
Open
correct [[deprecated]] attribute placement on class#3142EricX-Zhao wants to merge 1 commit intoros2:rollingfrom
EricX-Zhao wants to merge 1 commit intoros2:rollingfrom
Conversation
…lass
The previous declaration placed the [[deprecated]] attribute between the class-key and the RCLCPP_PUBLIC visibility macro:
class RCLCPP_PUBLIC [[deprecated(\"...\")]] MemoryStrategy
This form fails to compile under GCC 11.2 because the parser cannot
correctly handle a C++ standard attribute followed by a GNU
__attribute__ (which RCLCPP_PUBLIC expands to on Linux) in the class
head, resulting in errors such as:
error: expected primary-expression before 'public'
error: expected '}' before 'public'
Move the [[deprecated]] attribute to the declaration position,
immediately before the class-key. This form is parsed reliably by
GCC, Clang, and MSVC, ensures the deprecation warning is actually
emitted at use sites, and also propagates to derived classes.
Signed-off-by: EricX-Zhao <ericzhao0325@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous declaration placed the [[deprecated]] attribute between the class-key and the RCLCPP_PUBLIC visibility macro:
This form fails to compile under GCC 11.2 because the parser cannot correctly handle a C++ standard attribute followed by a GNU attribute (which RCLCPP_PUBLIC expands to on Linux) in the class head, resulting in errors such as:
Move the [[deprecated]] attribute to the declaration position, immediately before the class-key. This form is parsed reliably by GCC, Clang, and MSVC, ensures the deprecation warning is actually emitted at use sites, and also propagates to derived classes.
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes Claude Code Opus4.6
Additional Information