Skip to content

Add support for building with micro-ROS#1319

Open
Amronos wants to merge 1 commit into
ros2:rollingfrom
micro-ROS:upstream-patches
Open

Add support for building with micro-ROS#1319
Amronos wants to merge 1 commit into
ros2:rollingfrom
micro-ROS:upstream-patches

Conversation

@Amronos
Copy link
Copy Markdown

@Amronos Amronos commented May 14, 2026

Description

This is an upstreaming (with some changes) of the various patches that have been getting maintained in https://github.com/micro-ROS/rcl for a few years.
This should prevent us from having to resolve conflicts every ROS 2 release, and make it possible to always deliver the latest rcl without having to update the fork every so often.
This mainly uses a new CMake option called RCL_MICROROS is used with #ifdef and #ifndef to modify the rcl code to work with micro-ROS.

Is this user-facing behavior change?

Did you use Generative AI?

No

Additional Information

This has been tested in micro-ROS/micro_ros_espidf_component#323.

cc: @EugenioCollado @Narukara

Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amronos

this is not one-time API agreement, the question that we are really asking here is that if we support micro-ROS rcl in ROS 2 mainline. i just do not know the current discussion or consensus for that, do we have on-going discussion or agreement about this? IMO this is going to be better maintenance for micro-ROS, but it would be easy enough to break micro-ROS as rcl grows because most of maintainers do not know the micro-ROS requirement. to avoid this situation, CI/CD pipeline to make sure before that. that brings me back to the original question above.

CC: @mjcarroll

Co-authored-by: acuadros95 <acuadros1995@gmail.com>

Co-authored-by: Antón Casas <antoncasas@eprosima.com>

Co-authored-by: EugenioCollado <eugeniocollado@eprosima.com>

Co-authored-by: julibert <julianbermudez@eprosima.com>

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Signed-off-by: Aarav Gupta <aarav@spikonado.com>
@Amronos Amronos force-pushed the upstream-patches branch from d5fbdf8 to 2991067 Compare May 15, 2026 07:06
@Amronos
Copy link
Copy Markdown
Author

Amronos commented May 15, 2026

Thanks for the quick reply, @fujitatomoya!
Sorry, I should have talked more about this in the original post.
We have nightly CI in the micro-ROS repositories that runs all our tests and builds on the latest ROS 2 sources.
The plan is that whenever something breaks, we will make a PR to this repository to fix it. It shouldn't be a problem for end-users as the breaking changes would usually be on rolling.
The overall goal of this PR is that we would no longer need to maintain the fork for newer ROS 2 distributions and fix conflicts regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants