Add support for building with micro-ROS#1319
Conversation
fujitatomoya
left a comment
There was a problem hiding this comment.
this is not one-time API agreement, the question that we are really asking here is that if we support micro-ROS rcl in ROS 2 mainline. i just do not know the current discussion or consensus for that, do we have on-going discussion or agreement about this? IMO this is going to be better maintenance for micro-ROS, but it would be easy enough to break micro-ROS as rcl grows because most of maintainers do not know the micro-ROS requirement. to avoid this situation, CI/CD pipeline to make sure before that. that brings me back to the original question above.
CC: @mjcarroll
Co-authored-by: acuadros95 <acuadros1995@gmail.com> Co-authored-by: Antón Casas <antoncasas@eprosima.com> Co-authored-by: EugenioCollado <eugeniocollado@eprosima.com> Co-authored-by: julibert <julianbermudez@eprosima.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Signed-off-by: Aarav Gupta <aarav@spikonado.com>
|
Thanks for the quick reply, @fujitatomoya! |
Description
This is an upstreaming (with some changes) of the various patches that have been getting maintained in https://github.com/micro-ROS/rcl for a few years.
This should prevent us from having to resolve conflicts every ROS 2 release, and make it possible to always deliver the latest
rclwithout having to update the fork every so often.This mainly uses a new CMake option called
RCL_MICROROSis used with#ifdefand#ifndefto modify therclcode to work with micro-ROS.Is this user-facing behavior change?
Did you use Generative AI?
No
Additional Information
This has been tested in micro-ROS/micro_ros_espidf_component#323.
cc: @EugenioCollado @Narukara