Add error percentage to cpu and ram monitor#548
Open
sangteak601 wants to merge 6 commits into
Open
Conversation
Author
|
@ct2034 |
ct2034
requested changes
Mar 30, 2026
ct2034
added
the
needs more work
ct2034
added
the
enhancement
Collaborator
|
@sangteak601 are you planning to work on this? |
Author
All comments are addressed now I believe. Can you take another look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, it is not possible to configure
cpu_monitororram_monitorto publish ERROR status. It would be good to have ERROR state. It would allow us to take actions before program exhibits unexpected behaviour.Also,
cpu_monitorwas updated to compare threshold to average cpu usage rather than individual cpu usage. This is aligned with howram_monitorworks and makes more sense, as in most cases users are more interested in average usage than individual usage.