feat: add rgba8 support - #109
Open
spurnvoj wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
rgba8support to theimage_encodingparameter: a new whitelist entry inGSCam::configure()and a matching"format", "RGBA"caps branch inGSCam::init_stream().publish_stream()needed no changes since it already derives frame size/step generically vianumChannels(image_encoding_).Jetson's
nvvidconvonly natively outputs 4-byte-aligned formats (RGBA/BGRx) or YUV, never plain RGB/BGR. Without this, a pipeline ending innvvidconv ! video/x-raw,format=RGBAhad no caps gscam's appsink would accept, and failed withcannot link outelement(...) -> sink.Same shape as add MONO16 / GRAY16_LE support #70 (MONO16/GRAY16_LE) - additive only, no changes to the generic publish path.
Impact
src/gscam.cpp(configure(),init_stream()),README.mdTesting status
What was tested:
How to repeat tests: