Switch Python lint tooling from isort/autopep8 to black - #23
Merged
destogl merged 2 commits intoAug 16, 2026
Merged
Conversation
…ingle-line imports Replace isort (--profile google) and autopep8 with black and pyupgrade, matching the pre-commit stack used in ros_team_workspace and ros2_control. Group same-module imports onto one line instead of one per line, and fix the flake8/pydocstyle findings the new tooling surfaces (unused imports, an f-string with no placeholders, one docstring summary line). Co-Authored-By: Norbert <norbert@agents.b-robotized.com>
Match ros2_control's full pre-commit-hooks set: check-added-large-files, check-ast, check-case-conflict, check-docstring-first, check-merge-conflict, check-symlinks, check-xml, debug-statements, mixed-line-ending, fix-byte-order-marker, and --allow-multiple-documents on check-yaml. Co-Authored-By: Norbert <norbert@agents.b-robotized.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--profile google, force-single-line) and autopep8 with black and pyupgrade, matching the pre-commit stack used inros_team_workspaceandros2_control.from module import a, b, cline instead of one line per name, wrapped by black when they exceed the line length.autostart_adapter.py, and one docstring summary line inparser.py.Testing
pre-commit run --all-files colcon build --packages-select foreman foreman_msgs colcon test --packages-select foremanResult: all pre-commit hooks pass; 49 tests, 0 failures.