fix(onion/saves): 'Beetle Supafaust' to 'Supafaust' - #256
Open
pawndev wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis PR corrects Onion's Supafaust save-directory name for SNES.
Confidence Score: 4/5Existing saves under the former directory name can disappear from sync results.
cfw/onion/data/save_directories.json Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
cfw/onion/data/save_directories.json:142
**Legacy Saves Become Undiscoverable**
When an existing Onion installation stores SNES saves under `Beetle Supafaust`, replacing that entry makes the scanner check only `Supafaust` and silently skip the old directory. Those saves then disappear from sync results, so the old name should remain as a compatibility alias.
Reviews (1): Last reviewed commit: "fix(onion/saves): 'Beetle Supafaust' to ..." | Re-trigger Greptile |
| ], | ||
| "snes": [ | ||
| "Beetle Supafaust", | ||
| "Supafaust", |
There was a problem hiding this comment.
Legacy Saves Become Undiscoverable
When an existing Onion installation stores SNES saves under Beetle Supafaust, replacing that entry makes the scanner check only Supafaust and silently skip the old directory. Those saves then disappear from sync results, so the old name should remain as a compatibility alias.
Prompt To Fix With AI
This is a comment left during a code review.
Path: cfw/onion/data/save_directories.json
Line: 142
Comment:
**Legacy Saves Become Undiscoverable**
When an existing Onion installation stores SNES saves under `Beetle Supafaust`, replacing that entry makes the scanner check only `Supafaust` and silently skip the old directory. Those saves then disappear from sync results, so the old name should remain as a compatibility alias.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#202