Fix NumPy-safe coefficient checks - #14
Open
rogeriojorge wants to merge 1 commit into
Open
rogeriojorge wants to merge 1 commit into
rogeriojorge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d_over_curvature_cvalsfrom being assignedset_dofs(), scalar initialization, automatic construction, padding, and NumPy coefficient inputsRoot cause
get_dofs()returns a NumPy vector, andset_dofs()assigns slices of that vector back to coefficient attributes. A subsequent calculation then evaluated expressions such asself.d_over_curvature_cvals == [], which attempt incompatible elementwise broadcasting for a non-empty NumPy array.The assignment typos in
Qic.__init__()andconstruct_qi_r2()also meant that generated coefficient arrays were silently discarded.Testing
python -m unittest -v qic.tests.test_d_over_curvatureon Python 3.11: 5 passedpython -m unittest -v qic.tests.test_d_over_curvatureon Python 3.12 with NumPy 2.5.2: 5 passeddconstruct_qi_r2()path: completes as orderr2withB2cQI_deviation_max = 3.2580160791439994e-10mpi4pyimport error seen on pristinemain; no new failures