Skip to content

State tracker 2026 01 - #850

Open
baranovmv wants to merge 2 commits into
roc-streaming:developfrom
baranovmv:state_tracker_2026_01
Open

State tracker 2026 01#850
baranovmv wants to merge 2 commits into
roc-streaming:developfrom
baranovmv:state_tracker_2026_01

Conversation

@baranovmv

Copy link
Copy Markdown
Member

Proceeding PR #828 with some fixes, such as:

  • Fix race in state tracker and refactor

  • Rework by reusing roc::core::Mutex,
    and Mutex is no longer a friend for semaphores.

  • Fix race[s] in StateTracker as gavv proposed
    here

  • Fix Darwin semaphore timeout semantics

* add statetracker wait(), implement semaphore using mutex and cond var in platform without sem_clockwait() to prevent semaphore:timed_wait() to hang when changing sysem time, add test cases for state tracker and semaphore
@baranovmv
baranovmv requested a review from gavv September 5, 2026 10:47
@baranovmv
baranovmv force-pushed the state_tracker_2026_01 branch from a4f5f71 to b2d312c Compare September 5, 2026 10:49
@baranovmv baranovmv self-assigned this Sep 5, 2026
@rocstreaming-bot

Copy link
Copy Markdown

🤖 Pull request has failed checks and was automatically marked as work-in-progress.
If you believe the failures are unrelated or you want an early review, click on the request review button. Otherwise, please fix failures before requesting review.

@rocstreaming-bot rocstreaming-bot added S-work-in-progress status: PR is still in progress and changing S-ready-for-review status: PR can be reviewed and removed S-work-in-progress status: PR is still in progress and changing labels Sep 5, 2026
Rework  by reusing roc::core::Mutex,
and Mutex is no longer a friend for semaphores.

Fix race[s] in StateTracker as gavv proposed
[here](roc-streaming#814 (comment))

Fix Darwin semaphore timeout semantics
@baranovmv
baranovmv force-pushed the state_tracker_2026_01 branch from b2d312c to 08f1f44 Compare September 5, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-ready-for-review status: PR can be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants