1986 set minimum selenium version#1988
Merged
emanlove merged 2 commits intoMay 16, 2026
Merged
Conversation
Adding Yuri's reasoning which I support and like, "The current >= 4.3.0 is from mid-2022 and predates Chrome for Testing, the download unzip fix, and several Selenium Manager improvements. Since we are now requiring Python 3.10+, there's no reason to support such an old Selenium floor. 4.25.0 (late 2024) is widely deployed, avoids all the known download issues, and still gives users flexibility — they're not forced to be on the absolute latest."
Updated Selenium version under latest and previous. Also renamed Firefox flavor or latest to lastest_firefox.
yuriverweij
approved these changes
May 16, 2026
Member
yuriverweij
left a comment
yuriverweij
left a comment
There was a problem hiding this comment.
Note: We should also update/review/refactor the CI.yml someday soon-ish. To have a more complete pipeline with more coverage when we make a release.
aaltat
reviewed
May 16, 2026
Contributor
aaltat
left a comment
aaltat
left a comment
There was a problem hiding this comment.
Selenium 4.25 is more than year and half old. I would at least use something from 2025, perhaps not from 2026. But I would aim for something less than year old.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting minimum require Selenium to 4.25.0 within requirements.txt. Also bumping up the latest and previous Selenium version with the select workflow.