Android longPress to initiate PointAnnotation draggable - #4267
Open
lochstar wants to merge 2 commits into
Open
Conversation
lochstar
requested a deployment
to
CI with Mapbox Tokens
July 30, 2026 00:59 — with
GitHub Actions
Waiting
lochstar
requested a deployment
to
CI with Mapbox Tokens
July 30, 2026 00:59 — with
GitHub Actions
Waiting
lochstar
requested a deployment
to
CI with Mapbox Tokens
July 30, 2026 00:59 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is based on an old discussion at #3425.
When multiple draggable
PointAnnotationare visible on a pan-able map, it is very easy to accidentally trigger the drag event of thePointAnnotationwhilst moving around the map.This issue only exists on Android, iOS already implements a long-press to start the drag. This PR aligns the behaviour.
How to verify
Example App > Show Point Annotation: tap selects, longPress then drag fires onDrag.
Whilst testing in the example app, I noticed there is a crash when pressing "Render Polygon above", I've added
asStringOrNullcheck to bothsetAboveLayerIDandsetBelow. Let me know if you want me to add the same to any of the other functions, e.g.setSourceLayerID.Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)