Skip to content

fix(envoy-client): release global handle after shutdown - #5848

Open
DevChiniwala wants to merge 1 commit into
rivet-dev:mainfrom
DevChiniwala:fix/envoy-client-release-global-handle
Open

DevChiniwala wants to merge 1 commit into
rivet-dev:mainfrom
DevChiniwala:fix/envoy-client-release-global-handle

Conversation

@DevChiniwala

Copy link
Copy Markdown
  • Release the cached global Envoy handle after shutdown cleanup.
  • Add regression coverage that verifies the callback context is released.

Fixes #5766

Copilot AI balanced review requested due to automatic review settings October 7, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues found

Reviewed commit 49f2fb2.

@DevChiniwala

Copy link
Copy Markdown
Author

The Co review passed with no findings. GitHub has not run the latest-head Rust CI because it requires maintainer approval: Rust CI. Could a maintainer approve that run so the Envoy lifecycle regression can be checked in CI? The cached handle is cleared only if it still belongs to the stopping instance, before the stopped notification is published.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native registry process does not exit after registry.shutdown() resolves (GLOBAL_ENVOY retains referenced TSFNs)

2 participants