Skip to content

chore(release): update version to 2.3.25 - #5847

Draft
NathanFlurry wants to merge 2 commits into
mainfrom
release/2.3.25
Draft

NathanFlurry wants to merge 2 commits into
mainfrom
release/2.3.25

Conversation

@NathanFlurry

@NathanFlurry NathanFlurry commented Oct 7, 2026 •

Copy link
Copy Markdown
Member
  • Bump publishable packages, Rust crate pins, and example dependencies to 2.3.25.
  • Install NASM in the Windows cross-build image so the release artifacts build with aws-lc-sys.

@railway-app

railway-app Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🚅 Deployed to the rivet-pr-5847 environment in rivet-frontend

Service Status Web Updated
frontend-cloud 😴 Sleeping (View Logs) Web Oct 7, 2026 at 1:30 am UTC
kitchen-sink 😴 Sleeping (View Logs) Web Oct 7, 2026 at 1:29 am UTC
frontend-inspector 😴 Sleeping (View Logs) Web Oct 7, 2026 at 1:26 am UTC
website ❌ Build Failed (View Logs) Web Oct 7, 2026 at 1:20 am UTC
ladle ✅ Success (View Logs) Web Oct 7, 2026 at 1:18 am UTC
mcp-hub ✅ Success (View Logs) Web Oct 7, 2026 at 1:16 am UTC

@claude

claude Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review: release 2.3.25 version bump

This is a mechanical bump of publishable packages, Rust crate pins and examples to 2.3.25, plus NASM in the Windows cross-build image. I only read the diff and didn't build or run anything.

Issues

  • Whitespace churn in engine/sdks/typescript/api-full/package.json. The whole file is rewritten, with tabs replaced by spaces (about 68 lines changed for a one-line version bump). The other package.json files use tabs. This is probably a side effect of the release tooling re-serializing the file. It obscures the real change and is inconsistent with the rest of the repo. Restore tab indentation so the diff is only the version line. If the tooling does this every release, it would be worth fixing there.
  • Check that nothing was left on an old version. Run a grep for stale 2.3.20/2.3.24 strings across Cargo.toml, package.json files and lockfiles (Cargo.lock, pnpm-lock.yaml) to confirm none remain. The =2.3.xx crate pins in Cargo.toml must all match.

Dockerfile (docker/build/windows-x64.Dockerfile)

  • Installing nasm with --no-install-recommends and cleaning the apt lists is correct. aws-lc-sys does need NASM for Windows targets.
  • Consider folding it into an existing apt-get install layer if there is one, to keep the layer count down. This is minor.
  • Confirm the Windows release build passes in CI. That is the only real validation of this change.

Process

  • Per CLAUDE.md, releases should be cut as a patch, which this is. Confirm the release was run with --version 2.3.25 --latest.
  • A Docker build change is bundled into a version bump. A separate fix(docker) change would be easier to revert or cherry-pick. This is optional.

I found no security or test-coverage concerns.

🤖 Generated with Claude Code

This branch had an error being deployed

1 failed deployment
rivet-frontend / rivet-pr-5847 — 3373a979 Deployed Oct 7, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant