Skip to content

chore: remove container runner and game server guides - #5846

Merged
NathanFlurry merged 1 commit into
mainfrom
remove-container-runner
Oct 6, 2026
Merged

NathanFlurry merged 1 commit into
mainfrom
remove-container-runner

Conversation

@NathanFlurry

Copy link
Copy Markdown
Member

Removes the container-runner crate and its examples, the Containers, Unity, and Godot integration docs, and the container-runner build, publish, and ignore-file wiring.

Website counterpart: https://github.com/rivet-dev/website/pull/new/remove-container-runner

@railway-app

railway-app Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🚅 Deployed to the rivet-pr-5846 environment in rivet-frontend

Service Status Web Updated
website ❌ Build Failed (View Logs) Web Oct 6, 2026 at 9:23 pm UTC
kitchen-sink 🕒 Building (View Logs) Web Oct 6, 2026 at 9:23 pm UTC
frontend-inspector 🕒 Building (View Logs) Web Oct 6, 2026 at 9:23 pm UTC
frontend-cloud 🕒 Building (View Logs) Web Oct 6, 2026 at 9:23 pm UTC
ladle 🕐 Initializing (View Logs) Web Oct 6, 2026 at 9:23 pm UTC
mcp-hub 🕐 Initializing (View Logs) Web Oct 6, 2026 at 9:23 pm UTC

@railway-app
railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5846 October 6, 2026 21:23 Destroyed
@NathanFlurry
NathanFlurry merged commit af58b81 into main Oct 6, 2026
2 of 8 checks passed
@NathanFlurry
NathanFlurry deleted the remove-container-runner branch October 6, 2026 21:23
@claude

claude Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review

This is a pure removal of the container-runner crate, its examples, and the build, publish and ignore wiring.

  • I found no leftover references to container-runner or container_runner in the workflows, scripts, docs or website directories. The needs: chains in publish.yaml still point at jobs that exist.
  • Cargo.toml and Cargo.lock both drop the crate, and no other workspace member depends on it.
  • The PR body says the Containers, Unity and Godot docs are removed, but no docs files appear in the file list. If they live in the separate website repo, merge that PR together with this one so the sidebar and sitemap don't link to deleted pages.
  • Removing the Unity example also drops the vendored third-party Bayou/FishNet files and their LICENSE, which is fine for a removal.
  • I only had a shallow checkout and couldn't diff publish.yaml, so I didn't check the 2 added lines in that file. Please confirm they only rewire the dependencies of the removed job, for example the needs list of the release job.
  • If the container-runner image or crate was published anywhere (Docker registry, crates.io), consider noting its deprecation for existing users.

No bugs or security concerns from what I could check. LGTM once the website counterpart is coordinated.

🤖 Generated with Claude Code

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues found

Reviewed commit fd41b9e.

This branch was successfully deployed

No deployments
rivet-frontend / rivet-pr-5846 — fd41b9eb Deployed Oct 6, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant