Skip to content

layouts: Replace layout test with responsive layouts #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tylernij wants to merge 1 commit into
base: master
Choose a base branch
from
Open

layouts: Replace layout test with responsive layouts #418

tylernij wants to merge 1 commit into from

Conversation

@tylernij
Copy link

@tylernij tylernij commented Oct 17, 2025

  1. Fix compose activity being hidden due to E2E
  2. Use default fit type for responsive layout
  3. Fix animations not playing
  4. Remove no longer needed riv file

@tytydraco
layouts: Replace layout test with responsive layouts
400ac3f 
Signed-off-by: Tyler Nijmeh <[email protected]>

Fix compose activity being hidden due to E2E

Signed-off-by: Tyler Nijmeh <[email protected]>

Use default fit type for responsive layout

Signed-off-by: Tyler Nijmeh <[email protected]>

Fix animations not playing

Signed-off-by: Tyler Nijmeh <[email protected]>

Remove no longer needed riv file

Signed-off-by: Tyler Nijmeh <[email protected]>
@tylernij tylernij force-pushed the feat-implement-rivs branch from c93c5e0 to 400ac3f Compare October 17, 2025 21:15
@tylernij
Copy link
Author

tylernij commented Oct 17, 2025

Reason for that force push was to restore that "no longer needed" riv file, as it is needed by LowLevelActivity.kt

@tylernij
Copy link
Author

tylernij commented Oct 17, 2025

Screen.Recording.2025-10-17.at.2.17.23.PM.mp4

@lancesnider
Copy link

lancesnider commented Oct 17, 2025

lgtm! I'll leave Erik to approve.

HayesGordon
HayesGordon requested changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First Android PR, exciting!

I'm just blocking this from merging as the changes need to happen on the Mono repository, that then get's automatically pushed downstream. If we merge anything directly downstream we'll be in a state where the mono repo is out of date and we'd have to manually fix things.

@HayesGordon
Copy link
Contributor

HayesGordon commented Oct 20, 2025

First Android PR, exciting!

I'm just blocking this from merging as the changes need to happen on the Mono repository, that then get's automatically pushed downstream. If we merge anything directly downstream we'll be in a state where the mono repo is out of date and we'd have to manually fix things.

We do allow for external contributions down-stream, but then we pull the commit and co-author it to mono, see these internal docs: https://github.com/rive-app/rive/blob/master/COMMUNITY_CONTRIBUTIONS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HayesGordon HayesGordon HayesGordon requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tylernij @lancesnider @HayesGordon @tytydraco