fix#885
Open
heymide wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close: #812
I've successfully fixed the thundering herd issue in CachingService.getOrSet ! Here's what was changed:
Injected DistributedLockService into CachingService using the @optional() decorator, which allows graceful fallback to the old behavior if the lock service isn't available
Modified getOrSet method :
Added lock key: lock:cache:{key}
Added configurable parameters: lockTimeoutMs , pollIntervalMs , maxWaitMs
On cache miss, tries to acquire a lock first
Lock holders: double-check cache, run factory, store result, then release lock
Non-lock holders: poll cache (with jitter) until either the result is available or timeout is reached
Added a private sleep helper to handle polling delays
Related Issue
Closes #812
Type of Change
Checklist