Optimize bytes copying after receiving a message from zmq#158
Open
hxzrx wants to merge 1 commit intorigetti:masterfrom
Open
Optimize bytes copying after receiving a message from zmq#158hxzrx wants to merge 1 commit intorigetti:masterfrom
zmq#158hxzrx wants to merge 1 commit intorigetti:masterfrom
Conversation
stylewarning
approved these changes
Jun 22, 2023
Contributor
|
This looks good and safe to me. MEMCPY will definitely be faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The utility function
unpack-foreign-msg-to-bytesusescffi:foreign-array-to-lispto copyzmqmessage to a lisp vector, this is very slow for large messages sincecffi:foreign-array-to-lispsets the lisp vector byte-to-byte in a loop.In this PR,
memcpyis used instead ofcffi:foreign-array-to-lispto copyzmqmessage to the lisp vector in one pass, and the result is very close to that of the C version ofzmq.