Build CI on the latest stable Go, not go.mod's floor - #36
Merged
Conversation
Every workflow derived its toolchain from go.mod's `go` directive. That directive is a language floor, so the toolchain it selects is the .0 release of that line, carrying whatever stdlib CVEs have been fixed since. My earlier fix for that raised the floor to 1.26.5, which worked but binds the two concerns together: each future patch release with a security fix would need another go.mod bump to keep govulncheck quiet. CI now asks for `stable` and always builds on the current patched release, while go.mod goes back to naming the minimum language version the code actually needs. This is the approach the template settled on after the same problem surfaced there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reciprocal of the fix that landed in go-cli-template.
Every workflow resolved its toolchain with
go-version-file: go.mod. That directive is a language floor, so the toolchain it selects is the.0release of that line, carrying whatever stdlib CVEs have been fixed since — which is howgovulncheckcame to fail with 13 findings during the port.My fix then was to raise the floor to
1.26.5. That works, but it binds two unrelated concerns: every future patch release with a security fix would need anothergo.modbump just to keep CI quiet.CI now asks for
stable, so it always builds on the current patched release, andgo.modgoes back to naming the minimum language version the code actually needs (1.26.0, for the generalisednew(expr)used in tests).Verified:
make checkpasses,go mod tidyis a no-op, andgovulncheckreports no vulnerabilities on the current toolchain.