Commit the go.sum that go mod tidy produces - #34
Merged
Conversation
go.sum was assembled by `go get` and never tidied afterwards, so it was missing the two go-cmp hashes that `go mod tidy` adds — go-cmp is a test dependency of goimports, which the repo pulls in through the `tool` directive in go.mod. CI never noticed because it runs `go mod verify` and `go mod download`, which are satisfied by the existing file. The visible symptom is that anyone running `go mod tidy` gets an unexplained diff, and goreleaser's release pipeline runs exactly that as a before-hook, so a release would have mutated go.sum mid-build. The tree is now idempotent under its own tooling: a second tidy is a no-op, `go mod verify` reports all modules verified, and `make check` passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
richhaase
commented
Jul 25, 2026
richhaase
left a comment
Owner
Author
There was a problem hiding this comment.
LGTM ✅
3 of 3 reviewers found no issues.
Reviewer comments
- Reviewer 1: The patch only adds checksums produced by
go mod tidy, andgo mod tidy -diffreports no remaining changes. It does not alter runtime behavior or break existing code.
Categorized as informational during summarization - Reviewer 2: The patch only adds checksums produced by
go mod tidy. Runninggo mod tidy -diffproduces no further changes, and the additions do not alter runtime behavior.
Categorized as informational during summarization - Reviewer 3: The patch only adds checksums produced by
go mod tidy.go mod verifysucceeds, andgo mod tidy -diffreports no remaining differences.
Categorized as informational during summarization
Posted by acr 0.20.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.sumwas assembled bygo getduring the port and never tidied afterwards, so it is missing the twogithub.com/google/go-cmphashes thatgo mod tidyadds. go-cmp is a test dependency ofgoimports, which the repo pulls in via thetooldirective ingo.mod:CI never caught it because it runs
go mod verifyandgo mod download, both of which are satisfied by the existing file. Two consequences:go mod tidygets an unexplained two-line diff.goreleaser.yamlrunsgo mod tidyas a before-hook, so cutting a release would have mutatedgo.summid-buildAfter this the tree is idempotent under its own tooling — a second
go mod tidyis a no-op,go mod verifyreports all modules verified, andmake checkpasses.My oversight from the port; found while dry-running
make release-snapshotto check the release path before any tag is cut.🤖 Generated with Claude Code