Repository navigation
fix(mcp): name the right selector or include when get_health or get_risk drops an argument - #4366
Open
RaghavChamadiya wants to merge 1 commit into
Open
RaghavChamadiya wants to merge 1 commit into
RaghavChamadiya wants to merge 1 commit into
Conversation
…isk drops an argument A get_health lookup that misses on an id minted for another selector (a fix1_ id passed as plan_id) carries a hint naming the right selector. The unknown_only_keys hint names the include an include-gated key needs, and get_risk names tests and blast in ignored_arguments when no changed_files were passed.
|
🔍 1 thing to check
✅ Health of changed files: 8.0 (unchanged)
CoveragePatch coverage 100.0% (26 of 26 changed executable lines covered)
Report from this run for 🧾 Evidence: 6 not known
AI review is paused: this repository reached its monthly spending limit. Bot settings 📊 See the full report for this PR Settings and updatesUpdated 2026-10-21 19:19 UTC |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
get_health(plan_id="fix1_...")returnedplan: null, resolved: falsewith nothing saying the id belongs infix_id, which reads as "no such plan". A detail lookup that misses on an id minted for another selector now carries ahintnaming the right one (Pass fix_first ids (fix1_...) as fix_id, not plan_id.). The id is never resolved under the other selector, so a swapped argument stays visible.unknown_only_keys_hintlistedperformance_opportunitiesandrefactoring_plansas valid keys without saying they needinclude=["performance"]/["refactoring"]. It now leads with the include each include-gated miss needs.get_risk(targets=[...], include=["tests"])droppedtests(andblast) silently. Withoutchanged_filesthey land inignored_argumentswith"requires": "changed_files".How
tool_health/details.py(fix1_, act_, finding_, refac, refop, perf, as minted in core) generalizes the existingfinding_idhint to every selector; applied after the lookup, on misses only.Verification
onlyhint with and without the include, get_risk targets-only vs PR mode).