Repository navigation
refactor(dataflow): give declared-type reading its own home - #3554
Merged
Merged
Conversation
BaseDefUseDialect carried a second responsibility: reading the type written at a declaration, over its own holder / wrapper kind sets. It now lives in a small DeclaredTypes dataclass the dialect exposes as declared_types; the C++ and TypeScript tweaks become subclasses of it. Behaviour is unchanged.
|
Reviewed the whole diff: nothing to fix. ✅ Health of changed files: 5.1 (unchanged)
📊 See the full report for this PR Settings and updatesUpdated 2026-10-11 19:16 UTC |
swati510
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseDefUseDialect (27 methods) read declared types over its own kind sets (
type_holder_kinds/type_wrapper_kinds), a separate responsibility that kept its LCOM4 at 2 (low_cohesion, high).That reading now lives in a small
DeclaredTypesdataclass in base.py, exposed on each dialect asdeclared_types. Per-language overrides keep working: C++ (*/&/const) and TypeScript (optional parameter| undefined) subclass it in their own modules. The one outside caller, extract_method_declared_types, callsdialect.declared_types.of(node).