Skip to content

The stale_governance description says the code moved on since the decision was last confirmed, which the finding does not check #4385

Description

@RaghavChamadiya

Summary

The stale_governance text in the health glossary says "the code has moved on since the decision was last confirmed". The finding never looks at confirmation or at whether the decision still holds. It only records that files the decision governs changed after the decision was recorded.

packages/ui/src/health/biomarker-glossary.ts:249

"The architectural decision governing this file has gone stale ... the code has moved on since the decision was last confirmed.",

Mechanism

  • The score is the "fraction of affected files that have changed since the record's birth" (analysis/decisions/staleness.py, compute_staleness, compared against created_at). Confirmation time is not an input, and a changed file does not mean the decision is wrong.
  • _stale_governance_findings (analysis/health/governance.py:131) turns that score into one finding per governed file.
  • docs/layers/DECISIONS.md describes the same evidence, so the glossary is the outlier. Other wording that goes past the evidence: analysis/health/suggestions.py:189-190 ("the decision hasn't been reviewed") and analysis/health/fix_first/text.py:355 ("is out of date").

Repro

git grep -n "last confirmed" origin/main -- packages
packages/ui/src/health/biomarker-glossary.ts:249

Impact

A reader is told the code has drifted from the decision, when the evidence only says governed files were touched after it was written.

Done looks like

Tests

packages/ui/__tests__/health/biomarker-glossary.test.ts: assert the text no longer says "confirmed". tests/unit/health/test_governance.py still passes.

Activity

  1. macholul commented on Oct 22, 2026

    @macholul

    hi I'd like to take this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions