Repository navigation
Add German /surprise landing page - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET-27032
Adds the German landing page at
/surprise, where the QR code on the trade-fair scratch cards points. It currently returns a 404.Tom_nov_1.mp4is converted with the ffmpeg command from the ticket intovideos/surprise-de.mp4: H.264 High, AAC, 720×1280, faststart (moovbeforemdat), 608 KB. The poster isassets/images/surprise-poster.jpg(49 KB). The original file is not committed._pages/surprise.htmlis a copy of_pages/rails-world-2026.html. It changes only the places listed in the ticket, plus the technical fixes it asks for: videoid/poster/preload="metadata", noautoplay, no empty<track>,loading="eager"on the background, andjs-surprise-ctaon the button. Prettier reformatted the self-closing<video>. The page isnoindexand stays out ofsitemap.xml.surprise_video_start,surprise_video_progress(video_percent: 50),surprise_video_completeandsurprise_cta_click(link_url) to thedataLayer, each at most once per page view. The CTA links to/without UTM parameters./surpriseis excluded from@saved_*,@browser_*and@unprefixed_page./en|fr|it/surpriseredirects with a 302 to/surprise/and keeps the query string.Verification
jekyll build --strict_front_matterandscripts/verify_site.rb: both pass (39 HTML files, 36 localized routes)./surprisewithAccept-Language: en→ 200./surprise/withdeploio_language=it→ 200./fr/surprise?utm_source=a&b=c→ 302 to/surprise/?utm_source=a&b=c./and/rails_world_2026/still redirect to/en/….[MESSE-KÜRZEL]in the ticket before implementing it, and it has not been set yet. I did not want to put a guessed value into production analytics. Once the abbreviation is known, add this next to@surprise_localized:feature/surprise-page, but our conventions require theshikigamiya/feature/27032-…prefix.scripts/pricing-calculator.test.mjsalready fail ondevelop(Economy · 1 GBvsSingle database · 1 GB, after "Change Locales"). That is unrelated to this PR.Task #671
🤖 Generated with Claude Code