Skip to content

Conversation

@sean-anderson-seco
Copy link

When registering a new TimeHandle, IsReadyForNewTimeGrant will be true. However, other handles may have already been granted time. The TimeSource will wait for these other active handles to finish (causing their TotalElapsedTime to increase). After all all active handles have finished, SynchronizeVirtualTime will attempt to update the TimeSource's ElapsedVirtualTime. However, the newly-added handle's TotalElapsedTime will still be the source's ElapsedVirtualTime from when the handle was added. This will prevent time from advancing. This will cause ExecuteSyncPhase to fail, since ElapsedVirtualTime will not equal NearestSyncPoint.

Fix this by initializing TimeHandle.TotalElapsedTime to TimeSource.NearestSyncPoint, which is the earliest time that time will be granted to the handle.

Fixes: 49d06a3 ("[#8661] Introduce new time framework.")

When registering a new TimeHandle, IsReadyForNewTimeGrant will be true.
However, other handles may have already been granted time. The
TimeSource will wait for these other active handles to finish (causing
their TotalElapsedTime to increase). After all all active handles have
finished, SynchronizeVirtualTime will attempt to update the TimeSource's
ElapsedVirtualTime. However, the newly-added handle's TotalElapsedTime
will still be the source's ElapsedVirtualTime from when the handle was
added. This will prevent time from advancing. This will cause
ExecuteSyncPhase to fail, since ElapsedVirtualTime will not equal
NearestSyncPoint.

Fix this by initializing TimeHandle.TotalElapsedTime to
TimeSource.NearestSyncPoint, which is the earliest time that time will
be granted to the handle.

Fixes: 49d06a3 ("[#8661] Introduce new time framework.")
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sean Anderson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants