Skip to content

fix: OGG/Opus audio truncation — final page lost in write_chunk finalize #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
will-assistant wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: OGG/Opus audio truncation — final page lost in write_chunk finalize #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions api/src/services/streaming_audio_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,15 @@ def write_chunk(
for packet in packets:
self.container.mux(packet)

# Closing the container handles writing the trailer and finalizing the file.
# No explicit flush method is available or needed here.
logger.debug("Muxed final packets.")
# Close the container FIRST — this writes the final OGG page
# (or other format trailer) to the output buffer. For OGG/Opus,
# the last page of audio data is only written during close().
self.container.close()
logger.debug("Closed container, final page/trailer written.")

# Get the final bytes from the buffer *before* closing it
# Now read the buffer which includes all trailing data
data = self.output_buffer.getvalue()
self.close() # Close container and buffer
self.output_buffer.close()
return data

if audio_data is None or len(audio_data) == 0:
Expand Down