Skip to content

CLI: Print final register and memory states#96

Merged
tperami merged 16 commits into
mainfrom
x86-print-final-states
May 7, 2026
Merged

CLI: Print final register and memory states#96
tperami merged 16 commits into
mainfrom
x86-print-final-states

Conversation

@s-prism
Copy link
Copy Markdown
Collaborator

@s-prism s-prism commented Mar 27, 2026

  • Can now pass the print-final-states flag on the command line
  • If this flag is passed, prints all possible final states of the register and memory locations that the test is concerned with. Also print relevant statistics that mcompare wants.
    • Currently, arm register names start with 'R' and not 'X' or 'W'. This won't match other litmus testing tools.
  • Example structure of what we print:
    Test MP Allowed
    States 3
    1:rax=0; 1:rbx=0;
    1:rax=0; 1:rbx=1;
    1:rax=1; 1:rbx=1;
    No (allowed not found)
    Observation MP Never 0 3

Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread cli/bin/main.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread .gitignore
Comment thread cli/lib/litmus/runner.ml Outdated
@s-prism s-prism force-pushed the x86-print-final-states branch from be15e47 to a7e0546 Compare April 1, 2026 15:30
@s-prism s-prism changed the title Print final register states, and in progress for memory states Print final register and memory states Apr 1, 2026
@s-prism s-prism marked this pull request as ready for review April 2, 2026 22:22
Copy link
Copy Markdown
Collaborator

@tperami tperami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to click "Submit review"

Comment thread cli/bin/main.ml
Comment thread cli/bin/main.ml Outdated
Comment thread cli/bin/main.ml Outdated
Comment thread cli/bin/main.ml Outdated
Comment thread cli/lib/litmus/testrepr.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
@tperami
Copy link
Copy Markdown
Collaborator

tperami commented Apr 3, 2026

Also waiting on #102

@s-prism s-prism force-pushed the x86-print-final-states branch 2 times, most recently from 309e179 to 1e12b40 Compare April 8, 2026 12:47
Comment thread cli/lib/litmus/minState.ml Outdated
Comment thread cli/lib/litmus/minState.ml Outdated
Comment thread cli/tests/unit/litmus/testrepr_test.ml Outdated
Comment thread cli/lib/litmus/minState.ml
Comment thread cli/lib/litmus/minState.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread cli/lib/litmus/minState.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
Comment thread cli/lib/litmus/runner.ml Outdated
@s-prism s-prism force-pushed the x86-print-final-states branch 2 times, most recently from 6d146b8 to 87cd22c Compare April 10, 2026 16:19
@s-prism s-prism force-pushed the x86-print-final-states branch from 534317e to 81c6638 Compare April 24, 2026 16:48
@s-prism s-prism force-pushed the x86-print-final-states branch from 81c6638 to 6cc025b Compare May 7, 2026 13:48
@s-prism s-prism force-pushed the x86-print-final-states branch from 6d03865 to bb66de0 Compare May 7, 2026 15:25
@tperami
Copy link
Copy Markdown
Collaborator

tperami commented May 7, 2026

@s-prism Can you re-run make headers, I think they're outdated (missing your name)

Copy link
Copy Markdown
Collaborator

@tperami tperami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tperami tperami changed the title Print final register and memory states CLI: Print final register and memory states May 7, 2026
@tperami tperami merged commit 164c040 into main May 7, 2026
1 check passed
@tperami tperami deleted the x86-print-final-states branch May 7, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants