Skip to content

Make x86 store forwarding mixed size#106

Merged
tperami merged 3 commits intomainfrom
x86-mixed-size
May 7, 2026
Merged

Make x86 store forwarding mixed size#106
tperami merged 3 commits intomainfrom
x86-mixed-size

Conversation

@s-prism
Copy link
Copy Markdown
Collaborator

@s-prism s-prism commented Apr 8, 2026

@febyeji
Copy link
Copy Markdown
Collaborator

febyeji commented Apr 21, 2026

Nice, reading through the diff two small suggestions came to mind:

  1. Ordering with X86-TSO: modify operational model and update ISA model #107: Since X86-TSO: modify operational model and update ISA model #107 renames addr_val → buffer_entry and refactors the surrounding
    lock/flush logic, might it be easier to land X86-TSO: modify operational model and update ISA model #107 first and rebase this one on top?

  2. Litmus test for mixed-size: It might be worth adding a litmus test demonstrating the new mixed-size
    forwarding behaviour (e.g. a 4-byte write followed by a 2-byte read into the same range).

Copy link
Copy Markdown
Collaborator

@tperami tperami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some bit-fiddling could be improved, I showed an example, otherwise good to go

Comment thread ArchSemX86/OperationalX86TSO.v Outdated
@tperami tperami merged commit f0c23c0 into main May 7, 2026
1 check passed
@tperami tperami deleted the x86-mixed-size branch May 7, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants