Better performance #2497
Open
Better performance #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a better performance, contatenated string in a loop were converted to string builder.
For a better performance, change the string concatenations in a loop to StringBuilder
remkop
reviewed
Nov 27, 2025
Owner
remkop
left a comment
remkop
left a comment
There was a problem hiding this comment.
To be honest, I’m not a fan of making the code more verbose for no reason.
Can you quantify the performance gains, and provide context to when (which scenarios) performance would be better? It would have to be significantly faster in common scenarios for me to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a better perfomance, string concatenations in a loop were change to StringBuilder objects.