-
Notifications
You must be signed in to change notification settings - Fork 158
Fix industry biosolids historical shares #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+32
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do they need to be exempt here and we need another equation? Shouldn't applying the same bound to ETS and ES lead to very similar resutls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On why industry solids need to be exempt from
q_shbiofe_up/lo:The industry bound enforces a maximum of 30% biosolids in industry solids, but only for the ETS sectors (steel, cement, chemicals). OtherInd (ES) should have no such requirement. However,
q_shbiofe_up/loapplies the historical bioshare target to ETS and ES markets independently. This led to a situation where, e.g. in the EU, both equations forced ~50% biosolids in ETS AND ES industry until 2020. The strict 30% ETS bound starts in 2025, creating some substantial jumps in solids bioshare in some regions.Before this PR, I decided the best solution was to exempt industry solids here and rely exclusively on the new bounds from 2005 onwards to constrain ETS industry solids to a maximum of 30% biosolids.
Why we need a separate equation:
Since the 30% bound applies only to ETS sectors, I expect that the net historical bioshare is still broadly respected, with ES sectors compensating by using up a bigger share of biosolids. I had hoped the model would do this by itself, but this doesn't work in e.g. India, which led to the issue you raised. The new equations therefore bound the combined ETS+ES bioshare in industry solids, making sure otherInd (ES) makes up for the lower bio share in ETS sectors.
Nb. These aggregated equations across
emiMktcould actually be applied to all sectors and FE, and replaceq_shbiofe_up/loentirely. I don't want to make such a change close to the new REMIND release, though. I could test it in a few days.