Correctly transfer the co2luc subcategories in the coupling#2395
Merged
Conversation
…the coupling. Until now, the set was empty, no emissions were transferred, and the values taken from the lookup table remained unchanged.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the MAgPIE→REMIND coupling for CO2 land-use change (CO2LUC) subcategories by using the correct domain so that CO2LUC subcategory values are actually transferred (instead of silently iterating over an empty intersection).
Changes:
- Update
p_co2lucSubassignment to indexemiMacMagpieCO2Suboverall_enty(matching its set declaration and other usages), enabling proper transfer fromf_macBaseMagpie_coupling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
merfort
reviewed
Jul 7, 2026
merfort
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot! I guess this is a candidate for the smallest REMIND PR ever 😁
merfort
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Use the correct domain (
all_entyinstead ofenty) for the setemiMacMagpieCO2Subto actually transfer the co2luc subcategories in the coupling. Until now, the set-domain combination was empty, no emissions were transferred, and the values taken from the lookup table remained unchanged.Type of change
Parts concerned
Impact
Checklist
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)