Fix nuclear units in declaration strings#2387
Open
aodenweller wants to merge 2 commits into
Open
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes several nuclear-related units in the declaration strings of parameters and variables. It doesn't change any code.
In
core/declarations.gmspm_eta_convisTWa_elec/Mt_Urfor nuclearpm_PEPriceistr$2017/Mt_Urfor uraniumSimilarly, in
31_fossil/declarations.gmssome units were wrong. Please check these in particular, maybe @LaviniaBaumstark?I also fixed the reporting in
remind2accordingly: pik-piam/remind2#806Type of change
Parts concerned
Impact
Checklist
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)