Update baseline scaling for waste and energy N2O emissions#2370
Open
gabriel-abrahao wants to merge 3 commits into
Open
Update baseline scaling for waste and energy N2O emissions#2370gabriel-abrahao wants to merge 3 commits into
gabriel-abrahao wants to merge 3 commits into
Conversation
Member
|
Does energy get worse for some regions, e.g. CHN, MEA, REF? |
Contributor
|
Just talking with @gabriel-abrahao : yes there are some countries getting worse. However, the global figure improves. Now the point here i sthat Gabiel changed a parameter scaling factor that Jessica introduced many years ago to match the global emissions. It is basically a global emission factor adjustment. We will use a region specific adjustment latter. For the moment we will leave it with that. |
Member
|
means, you want to merge it, or not? |
Contributor
Author
Yes! Just waiting on a review. Nico already OKd it |
LaviniaBaumstark
approved these changes
Jun 22, 2026
nicobauer
approved these changes
Jun 22, 2026
Contributor
|
Thanks @gabriel-abrahao !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
On the waste side, this updates the reference for calculating the econometric parameters of the waste N2O emissions. Now it should use the most recent CEDS data with the reference year 2020, being consistent also with the CH4 waste reference.
On the energy side, it updates a hardcoded factor that's applied on Energy N2O emission factors. It was used to matched global energy N2O emissions from EDGAR, now it's updated to match the current CEDS in 2020. As it's a global factor, it only really nails global values, with substantial regional discrepancies (as before)
This brings our total N2O closer but still quite far from the CEDS reference. Likely due to the non-represented sectors.
Partially addresses issue 18. See the issue for a more in-depth discussion.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
Runs with these changes are here:
/p/projects/piam/abrahao/scratch/smip_check/remindComparison of results (what changes by this PR?):
Total N2O
Waste
Energy (supply)