Return an empty collection when where(:foo => []) is given#412
Open
chewi wants to merge 1 commit intoremi:masterfrom
Open
Return an empty collection when where(:foo => []) is given#412chewi wants to merge 1 commit intoremi:masterfrom
chewi wants to merge 1 commit intoremi:masterfrom
Conversation
Collaborator
|
hi @chewi I've just got commit access on this repo and plan to get back on track with maintenance over time - will be in touch soon! |
chewi
force-pushed
the
where-empty-array
branch
from
032d88f to
96df4eb
Compare
Contributor
Author
|
Rebased. |
chewi
force-pushed
the
where-empty-array
branch
from
96df4eb to
25e8700
Compare
Contributor
Author
|
Rebased again. |
Contributor
Author
|
And again! |
The previous behaviour was to return everything! This is now consistent with ActiveRecord and avoids a needless request. The new behaviour is not applied to has_one associations as they currently seem to ignore the where method entirely.
chewi
force-pushed
the
where-empty-array
branch
from
5f14a5b to
e8ec222
Compare
voltechs
added a commit
to TwilightCoders/her
that referenced
this pull request
Mar 31, 2026
Ref: remi#412 Short-circuit to an empty Her::Collection when any query parameter is an empty array, avoiding a pointless HTTP request that would return all records instead of none.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behaviour was to return everything! This is now consistent with ActiveRecord and avoids a needless request.
The new behaviour is not applied to has_one associations as they currently seem to ignore the where method entirely.