Skip to content

Move aar_init_script off legacy AGP APIs - #9

Open
reidbaker-agent wants to merge 1 commit into
agp-add-to-appfrom
agp-aar-script
Open

Move aar_init_script off legacy AGP APIs#9
reidbaker-agent wants to merge 1 commit into
agp-add-to-appfrom
agp-aar-script

Conversation

@reidbaker-agent

@reidbaker-agent reidbaker-agent commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Phase 9 of 11 of the AGP public-API migration; stacked on #8.

Phase P8 of the AGP public-API migration (flutter#180137,
flutter#166550):

  • The library-project check no longer probes for the legacy
    android.libraryVariants property (absent under the new DSL); it
    checks for the com.android.library plugin. Error message unchanged.
  • The plugin-to-module assembleAar task wiring enumerates published
    variants through the public software components (which the script
    already used for task creation) instead of libraryVariants.
  • The singleVariant dedup guard no longer reads the internal
    publishing.singleVariants collection. Flutter now marks projects it
    configured with an ext property and declares each variant's
    publishing in a try-catch: when the project's own build file already
    declared publishing for a variant, the user's declaration wins and a
    warning explains the situation and the fix. (Previously any
    user-declared variant silently disabled Flutter's publishing setup
    for ALL variants, which broke partially-declared projects at
    publication time with no explanation.)

Verification (CI): flutter build aar with and without flavors for
module and plugin projects; AAR-host add-to-app flow; a scratch module
with a partial user singleVariant declaration; newDsl=true aar flow.

Revert-safe even after P10, but not after P9.

CI must run the FGP unit tests (the Kotlin suite in packages/flutter_tools/gradle could not run in the delivery sandbox: dl.google.com returns 403, so AGP artifacts do not resolve).

@reidbaker-agent reidbaker-agent mentioned this pull request Jul 22, 2026
Open
@reidbaker-agent
reidbaker-agent force-pushed the agp-aar-script branch 2 times, most recently from 65bafb0 to 39f0c33 Compare July 30, 2026 21:58
@reidbaker
Move aar_init_script off legacy AGP APIs
7aa69dc 
Phase P8 of the AGP public-API migration (flutter#180137,
flutter#166550):

- The library-project check no longer probes for the legacy
  android.libraryVariants property (absent under the new DSL); it
  checks for the com.android.library plugin. Error message unchanged.
- The plugin-to-module assembleAar task wiring enumerates published
  variants through the public software components (which the script
  already used for task creation) instead of libraryVariants.
- The singleVariant dedup guard no longer reads the internal
  publishing.singleVariants collection. Flutter now marks projects it
  configured with an ext property and declares each variant's
  publishing in a try-catch: when the project's own build file already
  declared publishing for a variant, the user's declaration wins and a
  warning explains the situation and the fix. (Previously any
  user-declared variant silently disabled Flutter's publishing setup
  for ALL variants, which broke partially-declared projects at
  publication time with no explanation.)

Verification (CI): flutter build aar with and without flavors for
module and plugin projects; AAR-host add-to-app flow; a scratch module
with a partial user singleVariant declaration; newDsl=true aar flow.

Revert-safe even after P10, but not after P9.
This was referenced Aug 10, 2026
Merged
Closed
@reidbaker-agent reidbaker-agent mentioned this pull request Aug 11, 2026
Open
10 tasks
pull Bot pushed a commit to Little-Star888/flutter that referenced this pull request Aug 12, 2026
@reidbaker-agent @reidbaker
[AGP 9.1.0 Migration #1] Add Android Gradle Plugin Public API migrati…
88fe7f2 
…on documentation (flutter#190842)

There are 2 files in this pr. One is a document the ai used to keep
track of work. More importantly it acts kind of like issues so it
references the items in future prs. The second is user facing website
documentation. I do not know if we will use it verbatim but for the set
of prs lets treat that md doc as human understandable documentation that
we must understand before landing the next pr.

Reviewers: When the pr is out of draft and your comments are fully
addressed please prioritize this pr over other work. The review bar is
higher, the number of reviews has more people and the work for the next
pr is already done.
 - @reidbaker 
---
Standard review context for this pr stack

This is PR is part of an 11 pr stack to migrate the "newdsl"
`gradle-api` specifically in agp 9.1.0.
The complete stack has pass pre submits, post submits and customer
tests.
https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=experimental/agp-gradle-api

All of the code was LLM authored. A mix of manual prompting, automatic
prompting, several models and adversarial review. The combined sessions
are enough that I cannot include relevant prompts like I have been doing
on other prs.

If you want to review the pr stack you can find it here. These prs will
be abandoned/closed as prs land into flutter/flutter.
1. reidbaker-agent#1 (branch:
agp-api-doc)
2. reidbaker-agent#2 (branch:
agp-internal-utils)
3. reidbaker-agent#3 (branch:
agp-buildmode-deps)
4. reidbaker-agent#4 (branch:
agp-plugin-buildtypes)
5. reidbaker-agent#5 (branch:
agp-ndk-fallback)
6. reidbaker-agent#6 (branch:
agp-assets-onvariants)
7. reidbaker-agent#7 (branch:
agp-apk-copy-versioncode)
8. reidbaker-agent#8 (branch:
agp-add-to-app)
9. reidbaker-agent#9 (branch:
agp-aar-script)
10. reidbaker-agent#10 (branch:
agp-newdsl-flip)
11. reidbaker-agent#11 (branch:
agp-gradle-api)

Follow up work is tracked in
flutter#190964

This work is urgent in the sense that we are worried that android will
publish agp 10 with no opt out but not so urgent that we are willing to
break flutter users because we didn't review or understand the code
because we were in a rush.

Breaking changes are expected as part of this work. There are patterns
the android team explicitly does not want apps to use and apis that have
no equivalent.

As part of the effort to ensure this work does not slip into ai slop,
prs from this stack will be reviewed by me (@reidbaker) before asking
for review. Then we will have 2 android expert reviewers also review the
every pr.

---
Agent authored pr description
This is PR 1 of 11 in the AGP 9.1.0 / public `gradle-api` migration
stack.

It adds the contributor-facing and website draft documentation for the
Flutter Gradle Plugin's migration to the Android Gradle Plugin public
Variant API, which unblocks building Flutter Android apps with AGP's
`newDsl=true` enabled.

Part of flutter#180137 and flutter#166550.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: reidbaker-agent <reidbaker@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reidbaker-agent @reidbaker