Compile the Flutter Gradle Plugin against the gradle-api artifact only - #11
Open
reidbaker-agent wants to merge 2 commits into
Open
Compile the Flutter Gradle Plugin against the gradle-api artifact only#11reidbaker-agent wants to merge 2 commits into
reidbaker-agent wants to merge 2 commits into
Conversation
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 22, 2026 15:54
1c7628d to
90e7f64
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
from
July 22, 2026 15:54
6f3cbbb to
334d7fa
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 28, 2026 13:36
90e7f64 to
e677b61
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
from
July 28, 2026 13:36
334d7fa to
c33ae34
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 28, 2026 13:37
e677b61 to
0469863
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
from
July 28, 2026 13:38
c33ae34 to
e968545
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 29, 2026 20:23
0469863 to
0c85338
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
from
July 29, 2026 20:25
13bc17f to
a0ab835
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 29, 2026 20:45
0c85338 to
45274d4
Compare
reidbaker-agent
force-pushed
the
agp-gradle-api
branch
3 times, most recently
from
July 31, 2026 16:16
ef2c92a to
154cdcd
Compare
reidbaker-agent
force-pushed
the
agp-newdsl-flip
branch
from
July 31, 2026 16:16
a850013 to
aae8462
Compare
reidbaker
force-pushed
the
agp-gradle-api
branch
from
July 31, 2026 18:07
154cdcd to
a8575b4
Compare
reidbaker
force-pushed
the
agp-newdsl-flip
branch
2 times, most recently
from
August 5, 2026 16:11
7b8bdf1 to
721dcf4
Compare
reidbaker
force-pushed
the
agp-gradle-api
branch
2 times, most recently
from
August 5, 2026 16:22
334c423 to
81f5052
Compare
Phase P10, the final phase of the AGP public-API migration (flutter#180137, flutter#166550): - build.gradle.kts swaps both AGP dependencies from the full com.android.tools.build:gradle artifact to com.android.tools.build:gradle-api. Compilation is now the proof that the plugin uses zero AGP internals (AGP 10 removes access to them entirely), on top of the InternalAgpApiImportTest source check and the validateNoCommonExtensionInBytecode bytecode check, which stay as fast-feedback guards. - FlutterPluginTest is rewritten on public-API mocks only: the AbstractAppExtension multi-interface mock, BaseExtension, CommonExtension, internal.dsl.DefaultConfig, and the legacy sourceSets/AndroidSourceDirectorySet mocks are gone. No test source references a full-artifact-only or internal type anymore. - The --android-skip-build-dependency-validation help text now warns that skipping validation cannot make unsupported AGP versions work: builds below the supported minimum fail in Gradle regardless. - The android tooling README gains the AGP-bump checklist step to run the FGP test suite against the new version's public API artifact (-PagpVersion axis) and links the migration doc. Verification (CI): full matrix per the migration doc (gradle unit tests on both AGP axes - now both against gradle-api; scratch-app matrix; add-to-app source/AAR flows; config-cache baseline). Dart analyzer clean on the changed tool file. Cleanly revertible in isolation.
reidbaker
force-pushed
the
agp-gradle-api
branch
from
August 6, 2026 14:37
81f5052 to
e303b7a
Compare
reidbaker
force-pushed
the
agp-newdsl-flip
branch
from
August 6, 2026 14:37
721dcf4 to
ab4dd34
Compare
This was referenced Aug 10, 2026
10 tasks
pull Bot
pushed a commit
to Little-Star888/flutter
that referenced
this pull request
Aug 12, 2026
…on documentation (flutter#190842) There are 2 files in this pr. One is a document the ai used to keep track of work. More importantly it acts kind of like issues so it references the items in future prs. The second is user facing website documentation. I do not know if we will use it verbatim but for the set of prs lets treat that md doc as human understandable documentation that we must understand before landing the next pr. Reviewers: When the pr is out of draft and your comments are fully addressed please prioritize this pr over other work. The review bar is higher, the number of reviews has more people and the work for the next pr is already done. - @reidbaker --- Standard review context for this pr stack This is PR is part of an 11 pr stack to migrate the "newdsl" `gradle-api` specifically in agp 9.1.0. The complete stack has pass pre submits, post submits and customer tests. https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=experimental/agp-gradle-api All of the code was LLM authored. A mix of manual prompting, automatic prompting, several models and adversarial review. The combined sessions are enough that I cannot include relevant prompts like I have been doing on other prs. If you want to review the pr stack you can find it here. These prs will be abandoned/closed as prs land into flutter/flutter. 1. reidbaker-agent#1 (branch: agp-api-doc) 2. reidbaker-agent#2 (branch: agp-internal-utils) 3. reidbaker-agent#3 (branch: agp-buildmode-deps) 4. reidbaker-agent#4 (branch: agp-plugin-buildtypes) 5. reidbaker-agent#5 (branch: agp-ndk-fallback) 6. reidbaker-agent#6 (branch: agp-assets-onvariants) 7. reidbaker-agent#7 (branch: agp-apk-copy-versioncode) 8. reidbaker-agent#8 (branch: agp-add-to-app) 9. reidbaker-agent#9 (branch: agp-aar-script) 10. reidbaker-agent#10 (branch: agp-newdsl-flip) 11. reidbaker-agent#11 (branch: agp-gradle-api) Follow up work is tracked in flutter#190964 This work is urgent in the sense that we are worried that android will publish agp 10 with no opt out but not so urgent that we are willing to break flutter users because we didn't review or understand the code because we were in a rush. Breaking changes are expected as part of this work. There are patterns the android team explicitly does not want apps to use and apis that have no equivalent. As part of the effort to ensure this work does not slip into ai slop, prs from this stack will be reviewed by me (@reidbaker) before asking for review. Then we will have 2 android expert reviewers also review the every pr. --- Agent authored pr description This is PR 1 of 11 in the AGP 9.1.0 / public `gradle-api` migration stack. It adds the contributor-facing and website draft documentation for the Flutter Gradle Plugin's migration to the Android Gradle Plugin public Variant API, which unblocks building Flutter Android apps with AGP's `newDsl=true` enabled. Part of flutter#180137 and flutter#166550. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: reidbaker-agent <reidbaker@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 11 of 11 of the AGP public-API migration; stacked on #10.
Phase P10, the final phase of the AGP public-API migration
(flutter#180137, flutter#166550):
com.android.tools.build:gradle artifact to
com.android.tools.build:gradle-api. Compilation is now the proof that
the plugin uses zero AGP internals (AGP 10 removes access to them
entirely), on top of the InternalAgpApiImportTest source check and
the validateNoCommonExtensionInBytecode bytecode check, which stay as
fast-feedback guards.
AbstractAppExtension multi-interface mock, BaseExtension,
CommonExtension, internal.dsl.DefaultConfig, and the legacy
sourceSets/AndroidSourceDirectorySet mocks are gone. No test source
references a full-artifact-only or internal type anymore.
that skipping validation cannot make unsupported AGP versions work:
builds below the supported minimum fail in Gradle regardless.
the FGP test suite against the new version's public API artifact
(-PagpVersion axis) and links the migration doc.
Verification (CI): full matrix per the migration doc (gradle unit tests
on both AGP axes - now both against gradle-api; scratch-app matrix;
add-to-app source/AAR flows; config-cache baseline). Dart analyzer
clean on the changed tool file.
CI must run the FGP unit tests (the Kotlin suite in packages/flutter_tools/gradle could not run in the delivery sandbox: dl.google.com returns 403, so AGP artifacts do not resolve).