-
Notifications
You must be signed in to change notification settings - Fork 74
Fix the audit's 21 P1s across kernel, API, client, exports and pyplot #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alek99
wants to merge
5
commits into
main
Choose a base branch
from
alek/audit-p1-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
46d8466
Fix the audit's 21 P1s across kernel, API, client, exports and pyplot
Alek99 b3c9963
Add news fragment for the P1 audit fixes (#508)
Alek99 7ce900a
Fix CI: commit the regenerated capabilities doc, make pyarrow optiona…
Alek99 76bb111
Address the review round on the P1 fixes
Alek99 6599e2b
Put bar tick_label ticks at the input positions, and assert real brow…
Alek99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| Twenty-one P1 defects from the 0.0.7 audit are fixed. Kernel: a non-string | ||
| message `type`, a pick past a histogram's bin count, and a subnormal-span | ||
| `density_view` window no longer raise inside the dispatcher, and `view_change` | ||
| records only finite, ordered, non-empty ranges. API: a log axis warns when it | ||
| drops non-positive points, non-finite continuous color/size values are not | ||
| drawn instead of painting as the colormap floor, `sankey_chart(xy.sankey(...))` | ||
| works, a hand-built `xy.Mark` fills in factory defaults instead of a KeyError, | ||
| bare pyarrow string arrays become categorical axes, and a missing facet column | ||
| is a ValueError. Client: a log axis zoomed inside one decade shows linear | ||
| fallback ticks instead of none (exports agree), and legend-hidden category | ||
| points no longer hover or show a tooltip. Exports: PDF honors `font-style`, | ||
| `font-family` (mapped to the base-14 faces), `letter-spacing`, and `opacity` | ||
| on text, and XML-illegal control characters are dropped so SVG and PDF never | ||
| emit unparsable documents. pyplot: `ticklabel_format` configures the | ||
| formatter instead of breaking export; spans and rules autoscale and take | ||
| `label=`; `series.plot(ax=)` works with pandas' locators; datetime limits, | ||
| ticks, and `fill_between` coordinates are accepted; `legend(handles=, | ||
| labels=)`, integer and tuple `loc`, `Line2D`/`Patch`/`Rectangle` legend proxies, | ||
| `plt.subplot(n, m, i)` creating only the requested cell, callable `plt.cm.*` | ||
| colormaps, `BarPatch` geometry getters, and a long list of common kwargs | ||
| (`zorder`, `clip_on`, `facecolors='none'`, `tick_label=`, `log=True`, ...) | ||
| are accepted. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: For subnormal windows whose endpoints fall in the same one-decimal exponential bucket, this fallback adds two ticks but formats both as the same label, such as
1.0e-320. Preserve the endpoint ticks while formatting the pair with enough exponential precision to keep their labels distinct.Prompt for AI agents