fix: guard verticalExaggeration against undefined to prevent Cesium crash#140
Merged
Conversation
airslice
previously approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Enabling terrain for the first time when
verticalExaggerationhas not beenconfigured causes a Cesium crash:
Root Cause
The previous code always passed
property?.scene?.verticalExaggerationdirectly to<Scene>. When this value was never configured, it was alwaysundefined— Resium saw no change between renders and never wrote anything to the Cesium scene, so Cesium kept its internal default of1.0untouched.The terrain-disable fix changed this: when terrain is disabled we now explicitly pass
1, and when terrain is re-enabled we passproperty?.scene?.verticalExaggeration. If no exaggeration is configured, the prop transitions from1(number) →undefined. Resium detects this as a prop change and actively callsscene.verticalExaggeration = undefined. Cesium'sVerticalExaggeration.getHeightrequiresscaleto be a finite number :undefinedis not, so it throws aDeveloperErrorand halts rendering.Fix
Add
?? 1soundefinedis never passed when terrain is enabled but noexaggeration value has been set: