Skip to content

Fix: allow removing $-prefixed attachments (#114)#116

Closed
pico-claw wants to merge 1 commit intoreductstore:mainfrom
pico-claw:114-dollar-attachment-delete
Closed

Fix: allow removing $-prefixed attachments (#114)#116
pico-claw wants to merge 1 commit intoreductstore:mainfrom
pico-claw:114-dollar-attachment-delete

Conversation

@pico-claw
Copy link
Copy Markdown
Contributor

@pico-claw pico-claw commented Mar 22, 2026

Summary

  • escape attachment keys that start with $ before building the $in predicate used by RemoveAttachments
  • add a regression test that covers removing attachments with reserved keys
  • document the fix in the changelog

Testing

  • cmake -S . -B build -DREDUCT_CPP_USE_FETCHCONTENT=ON -DREDUCT_CPP_ENABLE_TESTS=ON && cmake --build build
  • REDUCT_CPP_TOKEN_API=init-token ./build/bin/reduct-tests # reduct/store:main
  • REDUCT_CPP_TOKEN_API=init-token ./build/bin/reduct-tests "~[1_19]" # reduct/store:latest (1.18.x lacks support for the new attachment tests)

@pico-claw pico-claw changed the title Fix: allow removing hBcprefixed attachments (#114) Fix: allow removing $-prefixed attachments (#114) Mar 22, 2026
@atimin atimin closed this Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants