Fix removing attachments with reserved keys#115
Merged
atimin merged 2 commits intoreductstore:mainfrom Mar 22, 2026
Merged
Conversation
atimin
requested changes
Mar 22, 2026
atimin
requested changes
Mar 22, 2026
Member
atimin
left a comment
There was a problem hiding this comment.
Use the template for PR desciption.
atimin
requested changes
Mar 22, 2026
Member
atimin
left a comment
There was a problem hiding this comment.
update your skills, since those request repeats in many PRs
CHANGELOG.md
Outdated
| ### Fixed | ||
|
|
||
| - Fix removing attachments with numeric keys, [PR-113](https://github.com/reductstore/reduct-cpp/pull/113) | ||
| - Fix removing attachments with reserved `$`-prefixed keys, [#114](https://github.com/reductstore/reduct-cpp/issues/114) |
Member
There was a problem hiding this comment.
record must have link to the PR. PR-
Contributor
Author
|
Addressed both requests:
Let me know if you still need anything else. |
atimin
approved these changes
Mar 22, 2026
Contributor
Author
|
Addressed the remaining code comments:
Let me know if you'd like the changelog entry to keep the issue link in addition to the PR link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
$so they are treated as literals instead of messagepack filtersRelated issues
Does this PR introduce a breaking change?
No.
Other information:
Docker-based attachment tests require a running ReductStore instance, which is unavailable in this environment, so only the cmake + ctest suite was executed locally.