iceberg/conversion: json schema improvements #29139
Draft
+461
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
force-pushed
the
nv/iceberg-json-schema
branch
from
0e17dfb to
6c57ad1
Compare
Refactor the JSON Schema to Iceberg type conversion to use a two-phase constraint solver architecture instead of the previous mixed traversal/conversion approach. Phase 1 (collect): Traverses the JSON Schema and builds a constraint structure with a bitfield tracking possible types, format annotations, and nested constraints for objects/arrays. Phase 2 (resolve): Resolves constraints to Iceberg types, rejecting schemas where type cannot be unambiguously determined. This design provides a cleaner separation of concerns and is more extensible for future JSON Schema keywords (allOf, anyOf, oneOf).
nvartolomei
force-pushed
the
nv/iceberg-json-schema
branch
from
6c57ad1 to
708ad06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes
Improvements