[RHDHBUGS-2644] Patch RAG Reference File Attributes in LLS 0.3.5#34
Merged
Jdubrick merged 1 commit intoredhat-ai-dev:mainfrom Feb 12, 2026
Merged
[RHDHBUGS-2644] Patch RAG Reference File Attributes in LLS 0.3.5#34Jdubrick merged 1 commit intoredhat-ai-dev:mainfrom
Jdubrick merged 1 commit intoredhat-ai-dev:mainfrom
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
maysunfaisal
approved these changes
Feb 12, 2026
Jdubrick
added a commit
to Jdubrick/llama-stack
that referenced
this pull request
Feb 12, 2026
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Jdubrick
added a commit
that referenced
this pull request
Feb 12, 2026
* patch for rag reference file attributes in lls 0.3.5 (#34) Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * prepare for v0.1.4 Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
For OpenAI models you will notice there are most likely some 'null' urls at the end of the referenced documents, for some reason OpenAI handles the call differently and those make it in after the patch. The good news is that all the referenced docs are there as well, so no information is missing. I think this small bug is okay to remain for TP as this patch is only for this version and will not be present in future releases in GA.
Note: This patch is temporary and only for 0.3.5 versions of Llama Stack, in the future this is fixed in 0.4.x+. I will be cherry picking this commit into our release branch and cutting a new release to contain it so we have the fix available.
Assisted by: Claude Opus 4.6
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/RHDHBUGS-2644
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer:
Pull PR changes, pull rag image with
make get-rag, build container, run all services as you normally would.